search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 519 forks source link

changed 3 more tests #872

Closed stevevance closed 6 years ago

stevevance commented 6 years ago

@Nyholm There is now only one test that's failing...I changed the adminLevel that it's checking from 3 to 4 but it's still failing.

Which leads me to question what API URL is being called. If it's Mapzen.com, it'll fail because that API doesn't work anymore. Geocode.earth is a drop-in replacement, but where do I change the URL to geocode.earth?

jbelien commented 6 years ago

Hello,

It's indeed Mapzen API that's requested ; as you can see here : Mapzen.php#L35

We know that Mapzen shutted down its services a few month ago. There is still an open issue (that you created) about this : #808 ; could you create a PR to add a new "geocode.earth" provider ? Thanks.

stevevance commented 6 years ago

@jbelien I've updated the URL, and it still fails.

jbelien commented 6 years ago

This PR is not necessary anymore, I fixed the MapzenTest.php file in #846 .

Nyholm commented 6 years ago

Thank you for the PR and thank you @jbelien for fixing this