Integrate Geoportail.lu geocoder

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.

https://geocoder-php.org

MIT License

3.95k stars 517 forks source link

Integrate Geoportail.lu geocoder #898

Closed frantzmiccoli closed 5 years ago

jbelien commented 5 years ago

Hello @frantzmiccoli ,

Thanks a lot for your contribution ! 👍

Before adding your provider to our list of third-party providers, could you use Geocoder\IntegrationTest\BaseTestCase in your test ? You can check the tests of any of our providers to see how it works.

Thanks !

EDIT: Geocoder\IntegrationTest\BaseTestCase is provided by geocoder-php/provider-integration-tests package.

frantzmiccoli commented 5 years ago

Hi!

I will try to do this in the next days.

Thanks,

frantzmiccoli commented 5 years ago

Hi @jbelien

It took me a bit more time to find time but it is done ;)

Thanks,

jbelien commented 5 years ago

Awesome ! Thanks a lot :) I'll have a look ASAP !

jbelien commented 5 years ago

See https://github.com/frantzmiccoli/geocoder-php-geoportail-lu/pull/1

frantzmiccoli commented 5 years ago

Accepted ;)