[Mapbox] Fix Mapbox Query builder when there is Bound

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.

https://geocoder-php.org

MIT License

3.95k stars 517 forks source link

[Mapbox] Fix Mapbox Query builder when there is Bound #906

Closed damienalexandre closed 5 years ago

damienalexandre commented 5 years ago

When using Bound, the query was malformed in two ways:

the format was wrong (| is not allowed);
~~the order was wrong (minLon,minLat,maxLon,maxLat was not respected).~~

I also added some documentation to the "Bound" object because it may not be clear to everyone what the min latitude can be when reading compass points.

jbelien commented 5 years ago

Thanks @damienalexandre ! 👍

damienalexandre commented 5 years ago

Oh gosh, you are right. I used this image as reference to build my test query but it's plain wrong...

PR Updated, commits squashed.

jbelien commented 5 years ago

New release of Mapbox provider 🎉

damienalexandre commented 5 years ago

Awesome thank you for your reactivity! :clap: