search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 517 forks source link

[Yandex] Location "kind" addition #914

Closed ReDev1L closed 5 years ago

ReDev1L commented 5 years ago

Pull request adds "Location kind": https://tech.yandex.ru/maps/doc/geocoder/desc/reference/kind-docpage/

Actually nothing special here

jbelien commented 5 years ago

Thanks a lot @ReDev1L

Could you add this new "field" in the tests ?

ReDev1L commented 5 years ago

Thanks a lot @ReDev1L

Could you add this new "field" in the tests ?

Dunno if it(yandex geocoder API) will return right kind for test, dont have phpunit atm, will fix later if not

UPD: actually it should pass: "Point":{"pos":"30.324285 60.036843"},"kind":"metro"}}

jbelien commented 5 years ago

Test seems okay 👍

But could you add it for the other tests as well ? Thanks !

ReDev1L commented 5 years ago

You dont have "name", "precision"(and now "kind") properties assertion in other tests, because other tests based on Location interface, not on YandexAddress model. I wont add them, you should split that task in another issue, because small refactor of tests required

jbelien commented 5 years ago

Indeed, you're right !

I'll merge your PR in the next few days ! Thanks a lot ! 👍

And if you have the courage to update the tests with YandexAddress model, feel free to sumbit a new PR 😄

ReDev1L commented 5 years ago

Thank you too. My courage will be depleted today, because i need to get Russian federal subjects by yandex geocoder :))

jbelien commented 5 years ago

I updated the tests : #919

jbelien commented 5 years ago

@ReDev1L Version 4.1.0 is released : https://github.com/geocoder-php/yandex-provider/releases/tag/4.1.0

Thanks again for your help 👍

ReDev1L commented 5 years ago

Thank you too =)