search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 517 forks source link

Added 'short_name' field for street name for google maps #918

Closed Tiraniel closed 1 year ago

Tiraniel commented 5 years ago

Added short street name field for Google Maps provider

jbelien commented 5 years ago

Hello @Tiraniel

Thanks a lot for your contribution ! Could you make sure the tests succeed by adding the .cached_response for your new testStreetShortNameWithRealAddress() test ?

Thanks.

Tiraniel commented 5 years ago

Hello @jbelien

Thanks for response. This is my first contribution attempt. Sure I'll make changes.

jbelien commented 5 years ago

Thanks a lot @Tiraniel ! Looking much better ! 👍

I realize that every component has a long_name and a short_name. Why limit your PR to route only ? Could you extend it to every component ?

PS: The test still fails but I'm having a look at it, don't worry about that.

Tiraniel commented 5 years ago

Sure. I can extend components with sort_name. Thanks for review!

jbelien commented 5 years ago

Hello @Tiraniel , any chance you could work on this ?

PS: It will need a rebase to apply our last updates.

Tiraniel commented 5 years ago

Hello @jbelien . Sorry, just back from long vacation. Will finish this week.

atymic commented 5 years ago

Can pick this one up if help is required :smile:

jbelien commented 4 years ago

@Tiraniel Any chance you could finish this PR ? Thanks.