geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 517 forks source link

Update GoogleMapsTest.php with API key #924

Closed jbelien closed 5 years ago

jbelien commented 5 years ago

Add Google Maps API key for every (not mocked) tests because "Keyless access to Google Maps Platform is deprecated."

Close #923

jbelien commented 5 years ago

🚨 Before merging it: src\Provider\GoogleMaps\Tests\.cached_responses needs to be cleaned and tests need to be updated !

Requires a Google Maps API key

Nyholm commented 5 years ago

Tests are updated with new responses. We are ready to merge =)

jbelien commented 5 years ago

Awesome, thanks a lot @Nyholm 👍

Unable to merge though because of the failing Photon test (due to PHP 7.0 vs PHP 7.1) :

Problem 1
    - This package requires php ^7.1 but your PHP version (7.0.25) does not satisfy that requirement.
Nyholm commented 5 years ago

I'll fix the broken build in an other PR