search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 517 forks source link

[OpenCage] Update StreetName Locality and SubLocality Mapping #931

Closed iborysenko closed 5 years ago

iborysenko commented 5 years ago

Updated mapping according to official configuration https://github.com/OpenCageData/address-formatting/blob/master/conf/components.yaml

jbelien commented 5 years ago

Hello @IvanBinzz , Thanks a lot for your contributoin 👍

Could you make sure your PR passes the tests ? Thanks !

eugenekurasov commented 5 years ago

https://github.com/geocoder-php/Geocoder/blob/fb3ba5acb9182cbd3be4ac5fc6a3557ae3e4fa51/src/Provider/OpenCage/Tests/OpenCageTest.php#L110 Change to $this->assertEquals('Lancaster Gate', $result->getStreetName());

jbelien commented 5 years ago

Great work @IvanBinzz @eugenekurasov 🎉

I'll merge this ASAP !

jbelien commented 5 years ago

I just released version 4.2.0! 🎉