Make sure we dont include multiple vendor folders

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.

https://geocoder-php.org

MIT License

3.94k stars 515 forks source link

Make sure we dont include multiple vendor folders #934

Closed Nyholm closed 5 years ago

Nyholm commented 5 years ago

This will fail until php-http/discovery:1.6 is released (Any hour now).

This will help #933

jbelien commented 5 years ago

Just restarted the build since php-http/discovery:1.6 is released.

Build still fails but it's due to "Array to string conversion" in PHP7.2. I'll fix it in a different PR ASAP ! 😃

Nyholm commented 5 years ago

It seams allright... Or, we got a minor issue with out test code on "deps=high". And on "deps=low" we should make sure to bump the version in discovery.

jbelien commented 5 years ago

Oh, that's weird, I don't see the "Array to string conversion" in the Travis log ... Well, not sure how to fix this then :/

Nyholm commented 5 years ago

I believe if we merge and tag this: https://github.com/geocoder-php/provider-integration-tests/pull/16

Then this PR will finally be happy =)

Nyholm commented 5 years ago

Thank you

jbelien commented 5 years ago

Awesome! We're back in the green :P

Nyholm commented 5 years ago

Wohoo