Open chriscalip opened 5 years ago
who wants it? will this fly warranting a patch?
Throwing it out there that this issue is BC and thus is fair to punt to a future discussion.
I guess this would have to be a 5.x.x
feature due to the BC break. Maybe worth revisiting if/when works begins on it?
example adoption:
From BeforeAdoption. a.) class:
Geocoder\ProviderAggregator
b.) method def:registerProviders(array $providers = []);
c.) sample method call:$geocoder->registerProviders([new \Geocoder\Provider\GoogleMaps\GoogleMaps($adapter), new \Geocoder\Provider\Yandex\Yandex($adapter),]);
To AfterAdoption. a.) class:
Geocoder\ProviderAggregator
b.) method def:registerProviders(Providers ...$providers);
c.) method call:$geocoder->registerProviders(new \Geocoder\Provider\GoogleMaps\GoogleMaps($adapter));
d.) method call:$geocoder->registerProviders(new \Geocoder\Provider\GoogleMaps\GoogleMaps($adapter), new XXProvider);
e.) method call:$providers = [new \Geocoder\Provider\GoogleMaps\GoogleMaps($adapter), new \Geocoder\Provider\Yandex\Yandex($adapter),]; $geocoder->registerProviders(... $providers);