search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.94k stars 515 forks source link

Algolia places provider is not working anymore #960

Closed jkobus closed 5 years ago

jkobus commented 5 years ago

Algolia Places response structure changed, therefore the provider is not working anymore. Algolia added localized names (client expects value but it instead sees another array): https://community.algolia.com/places/api-clients.html#json-answer

Algolia is also missing its factory.

jbelien commented 5 years ago

Thanks for the notice @jkobus !

Would you have some time to provide a PR ?

jkobus commented 5 years ago

In a spare time, sure. Todo:

jbelien commented 5 years ago

Ping @Fabex the original author of Algolia Places provider !

atymic commented 5 years ago

Happy to jump on this when I have some time if required :)

atymic commented 5 years ago

I've opened a PR. @jkobus what do you mean by adding a factory?

jbelien commented 5 years ago

New release is published: https://packagist.org/packages/geocoder-php/algolia-places-provider 🎉

jkobus commented 5 years ago

@atymic factory is for the symfony bundle (https://github.com/geocoder-php/BazingaGeocoderBundle/blob/master/Resources/doc/index.md#usage), although it is possible to use the geocoder provider without it.