search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 516 forks source link

feat: add geocode-earth provider #962

Closed atymic closed 5 years ago

atymic commented 5 years ago

This adds a new provider for https://geocode.earth/

They don't seem to have any public API docs, nor a free version of the API available without signup. I've flicked them an email asking for a test key + API docs.

For the moment all the tests are failing due to this, i'll resolve this once I get the test key

I'm also not sure of the exact process for creating a new provider, so let me know what needs to be fixed

Resolves #808

Thanks :smile:

jbelien commented 5 years ago

Thanks a lot for this ! 🎉

Could you make sure it passes all the tests ? I just had a quick look and I think there is just the .cached_response files missing in your PR.

atymic commented 5 years ago

Could you make sure it passes all the tests ? I just had a quick look and I think there is just the .cached_response files missing in your PR.

Just waiting for them to drop me some test API keys :)

atymic commented 5 years ago

The tests seem to be failing on php < 7.1, maybe due to serialisation changes? Not sure how to best resolve this.

jbelien commented 5 years ago

To fix the failed test, add <server name="GEOCODE_EARTH_API_KEY" value="YOUR_GEOCODE_EARTH_API_KEY" /> also in the main phpunit.xml.dist.

atymic commented 5 years ago

Done, thanks @jbelien :)

atymic commented 5 years ago

Is there anything else required for this PR?

jbelien commented 5 years ago

Sorry, didn't have time to properly have a look at it yet! I'll do that ASAP :)

atymic commented 5 years ago

No worries, sorry to bug 😄

jbelien commented 5 years ago

Thanks a lot for the PR @atymic !

@Nyholm We have a new provider 🎉 Could you create the new sub-package ? Thanks.

atymic commented 5 years ago

No worries 😄