search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.94k stars 515 forks source link

Feat #942 implement provider lookup method #979

Closed franzwilding closed 1 year ago

atymic commented 4 years ago

If you need any help getting this done let me know @franzwilding :)

jbelien commented 4 years ago

We indeed need to update all the providers and add an UnsupportedOperation on the lookupQuery for those who do not support this operation (just like reverseQuery in AlgoliaPlaces, for instance)

Nyholm commented 4 years ago

I dont think we can add a UnsupportedOperation . That would violate Liskov substitution principle.

I think we should create a new interface for this new feature (instead of modifying Geocoder). Then maybe a new trait (instead of modifying GeocoderTrait).

That will make it easy to add to providers one by one. (Or just the one we like). It will also avoid breaking BC.

mrelliot69 commented 1 year ago

was this ever pushed?

jbelien commented 1 year ago

was this ever pushed?

No, we are still waiting for an update from the author.