search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.94k stars 516 forks source link

Extend Geocode Earth provider for use of Pelias on other servers. #982

Closed jbelien closed 4 years ago

jbelien commented 4 years ago

Geocode Earth API uses open-source geocoder Pelias.

I extended this provider so we can change the API url and use another server using Pelias.

atymic commented 4 years ago

Maybe worth renaming it to something else, as Geocode Earth doesn't exist anymore 🤔. PeliasProvider ?

jbelien commented 4 years ago

@atymic I think you're confusing with Mapzen. Geocode Earth still exists :)

I'm planning to add in the main README both Geocode Earth and Pelias pointing to Geocode Earth provider.

atymic commented 4 years ago

Oh, my bad. Sorry :P Getting confused with the other provider.

jbelien commented 4 years ago

@atymic I asked https://geocode.earth/ for a API key (free trial) a few weeks ago but didn't have any reply. Since you created this provider, I guess you have one ; would you mind sharing it with me ? Thanks.

atymic commented 4 years ago

@jbelien

Sure thing, i've followed you on twitter. I'm DM you the key once you follow me.

Thanks!

jbelien commented 4 years ago

@atymic I'm actually refactoring this by creating an (abstract) Pelias provider. :P

Thanks for your first comments, I'll add it to the new provider!

jbelien commented 4 years ago

See #1004 for the new Pelias (abstract) provider.

jbelien commented 4 years ago

Superseded by #1005.

atymic commented 4 years ago

@atymic I'm actually refactoring this by creating an (abstract) Pelias provider. :P

No worries, I got a request to review from github.