search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.94k stars 516 forks source link

[MaxMindBinary] Issue with geoip 1.1.1 #983

Closed jbelien closed 4 years ago

jbelien commented 4 years ago

Don't have time to have a deeper look at it now but maybe someone knows how to fix this. There is an issue in the PHP 7.3 deps="low" and PHP 7.3 deps="high" builds (see https://travis-ci.org/geocoder-php/Geocoder/builds/561973179)

Problem 1
    - Installation request for ext-geoip 1.1.1 -> satisfiable by ext-geoip[1.1.1].
    - geoip/geoip v1.17 conflicts with ext-geoip[1.1.1].
    - Installation request for geoip/geoip ^1.17 -> satisfiable by geoip/geoip[v1.17].
jbelien commented 4 years ago

Damn that's blocking all the PR at the moment! 😭

I'll try to find some time to check ! @Nyholm any idea why it happens for deps="low" and deps="high" only ?

atymic commented 4 years ago

Look like it's failing because only the low/high deps try to use the geoip extensions: 

echo "$COMPONENTS" | parallel --gnu -j10% "tfold {} 'cd {} && $GEOIP_EXT && $COMPOSER_UP && $PHPUNIT_X$LEGACY'"
atymic commented 4 years ago

And the reason it's failing is because geoip/geoip requires the extension NOT to be installed: https://github.com/maxmind/geoip-api-php/blob/master/composer.json

"conflict": {
    "ext-geoip": "*"
},
atymic commented 4 years ago

PR open in #985 :)

jbelien commented 4 years ago

Awesome! Nice catch @atymic 👍

atymic commented 4 years ago

No worries :)