geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.95k stars 516 forks source link

[Chain] Improve error message when provider can not *reverse* geocode #986

Closed jbelien closed 5 years ago

jbelien commented 5 years ago

Apply PR #880 for reverse geocoding

simonschaufi commented 5 years ago

@jbelien Hi, I have the problem, that the placeholders don't get replaced any more in my error message after this change. My error message looks like this: 'Provider "{providerName}" could not reverse geocode coordinates: {latitude}, {longitude}".',. I don't see any point where the placeholders get replaced. I guess something like sprintf is missing (which was there before but got dropped).