search

geocoder-php / Geocoder

The most featured Geocoder library written in PHP.
https://geocoder-php.org
MIT License
3.94k stars 516 forks source link

[Here] Fix reverse geocoding (a typo was present in the prox parameter) #991

Closed DamienHarper closed 4 years ago

DamienHarper commented 4 years ago

Fix reverse geocoding (a typo was present in the prox parameter) Bump API version from 8 to 9

DamienHarper commented 4 years ago

@jbelien I have no idea why 4 out of the 6 jobs are failing on Travis :/

atymic commented 4 years ago

@DamienHarper they are failing because the URLs have changed, so not there are no cached responses for these requests.

You need to copy phpunit.xml.dist to phpunit.xml and add your HERE api keys. Then, delete all the cached responses are run the tests (which will generate/save the new cached responses).

Then you should commit those cache files, and travis will use them for the tests.

It would also be good to add a test to cover the bug you fixed, if possible.

DamienHarper commented 4 years ago

@atymic thanks for the guidelines, everything's ok now

jbelien commented 4 years ago

Does the upgrade to version 9 of the API has an impact ?

DamienHarper commented 4 years ago

@jbelien No, they only added timezone information in responses (which is not handled/ignored by the Here provider as of now) More information here: https://developer.here.com/documentation/geocoder/topics/backwards-compatibility.html#backwards-compatibility__api-different-generations

jbelien commented 4 years ago

Thanks a lot @DamienHarper ! 🎉

New release 0.2.1 is now available: https://packagist.org/packages/geocoder-php/here-provider