search

geocoder-php / GeocoderLaravel

Geocoder service provider for Laravel
http://geocoder-php.org/GeocoderLaravel/
MIT License
701 stars 102 forks source link

The project doesn't need to use Testbench BrowserKit #121

Closed crynobone closed 6 years ago

crynobone commented 6 years ago

From what I see in the tests folder, you don't actually need Testbench BrowserKit, FeatureTestCase should just extends Orchestra\Testbench\TestCase.

Testbench

It's loads Laravel apps and able you to run artisan commands, migrations, basic routing from within your tests.

Testbench BrowserKit

It extends Testbench an allow you to interact with the view using CSS selectors (interacting with form, button, link etc) but without JavaScript.

Testbench Dusk

It extends Testbench an allow you to interact with the view using CSS selectors (interacting with form, button, link etc) with JavaScript (using Chrome browser).

mikebronner commented 6 years ago

Right, I know they aren't necessary. My dev workflow includes this encompassing setup. I have moved to this for all my packages, and like to keep the same workflow for all packages for maintenance and ease of use. :)

But you're right, the existing tests don't utilize any browser actions.