Closed tooblue closed 5 years ago
@tooblue Good PR! Thanks :) I'll take a look at this over the next day or so. :)
@tooblue Could you give release 4.2.4 a try and let me know if it works for you?
@mikebronner That works! Thanks very much. :)
Awesome! :) I changed the syntax around a bit to better match the other array-notations. Thanks for your work on this! :)
Laravel does not support closures within the config files (https://github.com/laravel/framework/issues/9625), and so setting the
geocoder.reader
configuration to an instance of\GeoIp2\Database\Reader
or\GeoIp2\WebService\Client
created problems when runningphp artisan config:cache
.With the changes I made, you could configure the
reader
like so:It also still supports the old method of setting the reader instance: