search

geocoder-php / geocoder-extra

Geocoder extra features.
MIT License
52 stars 13 forks source link

Geocodio fixes not in stable package #28

Closed patrickcarlohickman closed 8 years ago

patrickcarlohickman commented 9 years ago

PR #21 fixed some issues with the Geocodio provider, but it looks like it was only merged into the 1.x branch. Is it possible to get this merged into a tagged release?

Let me know if there are any questions, or if my understanding is incorrect. Thanks!

vicchi commented 8 years ago

@willdurand @Nyholm Looks like this is still the case as the 1.x branch is 4 commits ahead of master?

willdurand commented 8 years ago

ahm maybe yes. so we should:

  1. tag a version for 1.x
  2. and then merge 1.x into master (which might be a little bit tricky)
vicchi commented 8 years ago

@willdurand Tagging 1.x retrospectively is a good idea. Maybe a cherry pick merge for point 2 might work though I'd assume this depends on how much drift there's been since 1.x was last updated.

Nyholm commented 8 years ago

Lets cherry pick the commit and put it to master.

Nyholm commented 8 years ago

Fixed in #46