search

geocoder-php / geocoder-extra

Geocoder extra features.
MIT License
52 stars 13 forks source link

Add Ip2cProvider #31

Closed ganeko closed 8 years ago

Nyholm commented 8 years ago

Could you rebase this PR on master?

ganeko commented 8 years ago

Done. Any help needed to update this PR to v3?.

Nyholm commented 8 years ago

You need to modify travis.yml to make sure we run tests for this provider. I can also see that there is some stuff missing for being compatible with v3 of the geocoder?

Any help needed to update this PR to v3?.

Are you asking for help or providing help?

If asking: Run composer update and you will see where PHP complains. There is five or six places you should update.

If providing: We will be happy to. There is currently a few issues that has some work. See #41 and #40. You may continue my work on #40 if you like.

ganeko commented 8 years ago

Hi,

I update my branch and all tests passed.

Sorry, I was asking about my PR for needed changes but I will check https://github.com/geocoder-php/geocoder-extra/pull/40

Nyholm commented 8 years ago

Thank you. I think this PR looks good.

The only thing missing is updating the table in Readme so we tell the world about the change =)

After that I will be happy to merge.

ganeko commented 8 years ago

Oops, sorry about that. Added and committed. Thanks!

Nyholm commented 8 years ago

Awesome!