search

geocoder-php / geocoder-extra

Geocoder extra features.
MIT License
52 stars 13 forks source link

Add what3words as a supported provider #42

Closed vicchi closed 8 years ago

vicchi commented 8 years ago

Note - due to the semantics of the what3words 3 word address scheme, this provider returns the 3 word address as the locality element of the returned Address. The coordinates and bounding box are also always returned in their usual place in Address.

A valid API key is also required to use the service and for the unit tests, this can be supplied in a local copy of phpunit.xml as <server name="WHAT3WORDS_API_KEY" value="a-valid-api-key" />

Nyholm commented 8 years ago

Good job 👍

willdurand commented 8 years ago

Try not to add merge branch ... as commit :)

vicchi commented 8 years ago

@willdurand Mea culpa!

willdurand commented 8 years ago

@vicchi no worry, was just a quick check for cosmetic stuff. I think you will have to squash your commits before getting this PR merged (cf. https://davidwalsh.name/squash-commits-git).

Good job by the way!

vicchi commented 8 years ago

Good point. I'll squash this down. Probably won't be until tomorrow now as I'll be in transit home in a short while.

willdurand commented 8 years ago

No rush ;-)

vicchi commented 8 years ago

OK - that should be squashed now (dived onto the flaky conference wifi)

vicchi commented 8 years ago

I've just merged in PR #31's changes to my gg-what3words-provider branch and it's building clean in Travis ... if there's no other comments, can this be merged into master?

Nyholm commented 8 years ago

Thank you

vicchi commented 8 years ago

Thanks @Nyholm. Much appreciated.