search

geocoder-php / geocoder-extra

Geocoder extra features.
MIT License
52 stars 13 forks source link

Tag 2.0.0? #44

Closed Nyholm closed 8 years ago

Nyholm commented 8 years ago

What is left to do before tagging 2.0? After the merge of #40 all tests will be green and we fully support Gecoder 3.0.

I want to tag 2.0 of geocoder-extra to make sure we have a working release with geocoder 3.0. Then tag 3.0 of geocoder-extra when 4.0 of geocoder is released.

@vicchi Do you have anything else you want to do before 2.0?

vicchi commented 8 years ago

@Nyholm I'd like to have one last pass through the open issues and see if we can clear them up

willdurand commented 8 years ago

I want to tag 2.0 of geocoder-extra to make sure we have a working release with geocoder 3.0. Then tag 3.0 of geocoder-extra when 4.0 of geocoder is released.

:+1:

Let's wait for @vicchi last pass, and then let's finally tag a new version!

Thanks for your great work ❤️

vicchi commented 8 years ago

There's 3 open PRs at the moment.

@Nyholm's PR #40 looks like it's passing all the tests and needs LGTM and/or +1's.

PR #34 looks like it needs some remedial work, plus it's failing on the unit tests, as is PR #33

In an ideal world I'd like to get these PR's either merged and/or updated and then merged or, worst case scenario, closed. Especially for the 2 oldest PR's which have asked for remedial action and which haven't, to date, been replied to.

Issue #30 seems to have gone quiet and issue #28 can probably be looked at and resolved.

I do plan on tackling all of the above, but I'm unsure as to timescales on all of this due to the day job.

Nyholm commented 8 years ago

Good, thank you.

I think we should do #34 and #28. I've updated the milestone: https://github.com/geocoder-php/geocoder-extra/milestone/1

@vicchi: Please review #40 and merge it if you like it.

vicchi commented 8 years ago

@Nyholm PR #40 is merged and closed. Nicely done

Nyholm commented 8 years ago

Thank you!

Nyholm commented 8 years ago

I've created #45 and #46. Please give those a review and I'll tag 2.0.0 later today.

vicchi commented 8 years ago

I'm also looking at PR #33 right now

vicchi commented 8 years ago

PR #33 needs work on the unit tests to pass; they've not been updated to reflect the new URLs that the Baidu provider now uses as a result of supporting v2 of their API. Which makes me think they haven't been run at all for this PR.

I'll go through them and a) try to fix them up to pass for the mocked tests and b) see if I can get hold of a live Baidu API key so we can test the live API calls.

Which will take longer than I anticipated, but such is life ....

Nyholm commented 8 years ago

That could be done after 2.0. Nothing will break BC, right?

vicchi commented 8 years ago

Right. Just reviewed #45 and #46. Both LGTM.

Let's punt the remaining issues and PRs 'till post 2.0 and then I'll make a concerted effort to clear up all the issues/PRs

Nyholm commented 8 years ago

Great.

@willdurand are you okey with me tagging 2.0.0 now?

willdurand commented 8 years ago

Yes. Can you do it or I take care of it? (tomorrow)

Nyholm commented 8 years ago

Cool, Im happy to do it.

willdurand commented 8 years ago

awesome!!!