geocoder-php / geocoder-extra

Geocoder extra features.
MIT License
52 stars 13 forks source link

geocoder.ca defaults to http and puts auth in query string #52

Open adjenks opened 3 years ago

adjenks commented 3 years ago

Just some suggestions about security.

Providers should default to using https when possible. It's better to start secure and let the user choose to downgrade. The geocoder provider defaults to http.

Providers should avoid putting authentication parameters in query strings because they are more likely to get logged somewhere, geocoder.ca accepts post requests, so this would be possible, but the provider code currently uses a query string parameter.