search

geocoders / geocoder-tester

Run search queries against a geocoder that supports geocodejson spec.
Other
40 stars 23 forks source link

Add testcases for various housenumber types #28

Closed hbruch closed 6 years ago

hbruch commented 6 years ago

Add some testcases for housenumbers with various suffixes, case variations, hyphenation etc.

nlehuby commented 6 years ago

@yohanboniface do you want to review this PR? Otherwise, I'll merge it.

hbruch commented 6 years ago

I just noticed I need to provide lang=de, so geocoder instances defaulting to english would return 'Hannover' instead of 'Hannover'.

hbruch commented 6 years ago

Another question: are there any conventions for the names of subfolders, e.g. modelling the osm admin-level hierarchy? Probably I should then rename the folder to niedersachsen?

yohanboniface commented 6 years ago

Another question: are there any conventions for the names of subfolders, e.g. modelling the osm admin-level hierarchy? Probably I should then rename the folder to niedersachsen?

There is no convention at this level. The constraint is that every subfolder is automatically transformed as a tag (so it can be used as filters when running py.test) so for example it should not contain dashes (otherwise they are parsed as "minus" by pytest). As you have certainly noticed, he usage is to have geographical subfolders, and inside them optional "typed" subfolders. I think we need to be consistent for the "typed" subfolders (given they are used several times), but geographical subfolders are fine as soon as people interested in this area understand its name.