geocoders / geocoder-tester

Run search queries against a geocoder that supports geocodejson spec.
Other
40 stars 23 forks source link

Reports error although no visible difference #32

Closed karussell closed 6 years ago

karussell commented 6 years ago

I get the following result:

Search failed
# Search was: Bautzener
# Params was: lon: 14.260983 - limit: 1 - lat: 51.440661
# Expected was: country: Germany | name: Bautzener Allee | postcode: 02677
# Results were:
name            | osm_key | osm_value | osm_id    | housenumber | street | postcode | city        | country | lat        | lon        | distance
--------------- | ------- | --------- | --------- | ----------- | ------ | -------- | ----------- | ------- | ---------- | ---------- | --------
Bautzener Allee | highway | tertiary  | 388210833 | —           | —      | 02977    | Hoyerswerda | Germany | 51.4405684 | 14.2610365 | —       

for a location bias request:

comment;query;lat;lon;expected_name;expected_country;expected_postcode
Hoyerswerda;Bautzener;51.440661;14.260983;Bautzener Allee;Germany;02677

which does not make any sense to me, because I cannot see any difference, also not from the pytestdebug.log

The raw geocoder response is:

{"features":[{"geometry":{"coordinates":[14.2610365,51.4405684],"type":"Point"},"type":"Feature",
"properties":{"osm_id":388210833,"osm_type":"W","extent":[14.2609224,51.4406793,14.2614896,51.4401282],
"country":"Germany","osm_key":"highway","city":"Hoyerswerda","osm_value":"tertiary",
"postcode":"02977","name":"Bautzener Allee","state":"Saxony"}}],"type":"FeatureCollection"}

It would be good if one could see which of the expected objects failed.

karussell commented 6 years ago

Uups postcode is wrong ;) ... but it would be helpful if this is easier to find out via more detailed logs instead of removing column by column

yohanboniface commented 6 years ago

We may display in bold each value that does not match in each column.

karussell commented 6 years ago

Or red :) ... or just assume people that can read ;)

yohanboniface commented 6 years ago

Yeah, red sounds better :)

karussell commented 6 years ago

Thanks!