covid - review - Githubissues

geocompr / geocompr.github.io

Place to host presentations, articles and other types of web content related to geocomputation with R, Python, etc.

https://geocompr.github.io/

9 stars 9 forks source link

covid - review #9

Closed Nowosad closed 4 years ago

Nowosad commented 4 years ago

@Robinlovelace some of my comments after looking and the blog post:

[x] It would be probably good not to download world data directly in the blog post. Maybe it is better to read it from file (or similar) with some hidden code?
[x] There are many code chunks (and their outputs) at the beginning of the blog post. Maybe some are not necessary?
[x] Not all animations are visible in the blog post
[x] I think the blog post needs some more text explaining the ideas and the code

Feel free to change whatever you think is necessary and publish the blog post

Robinlovelace commented 4 years ago

Hi @Nowosad thanks for this. The blog post was 'code only' so will add some text and simplify the code. I think regarding 1) it's OK to download data but happy to consider alternatives, what would you suggest? Wanting to avoid pushing data into the repo.

Nowosad commented 4 years ago

Could you use piggyback in this case as well? I made that point, because when rnatualearthdata server is slow, then the website build could break.

Nowosad commented 4 years ago

@Robinlovelace the blog post looks great. One thing - the final animation should be updated - it is different from the current code results.

Robinlovelace commented 4 years ago

Yes, all good. WIP.

Robinlovelace commented 4 years ago

Demo of simple animated map:

covid-19-animated-map-test