geocompx / geocompy

Geocomputation with Python: an open source book and online resource for getting started in this space
https://py.geocompx.org/
Other
259 stars 47 forks source link

readme clean #204

Closed Robinlovelace closed 10 months ago

Robinlovelace commented 10 months ago
Robinlovelace commented 10 months ago

Regarding Binder, it did work last time I tried it:

image

However, the image was v. out of date. Let's try with the updated settings...

itamarst commented 10 months ago

You probably want to tell people to install with pip inside a virtualenv.

Robinlovelace commented 10 months ago

You probably want to tell people to install with pip inside a virtualenv.

Aha, good idea, so as not to install system-wide right?

Robinlovelace commented 10 months ago

So it would be something like:

python3 -m venv geocompy
source geocompy/bin/activate
pip install -r requirements.txt

Right? Looking at this: https://packaging.python.org/en/latest/guides/installing-using-pip-and-virtual-environments/

Robinlovelace commented 10 months ago

Regarding Binder, it does actually work now. Worth re-adding mention of it to the README?

image

Robinlovelace commented 10 months ago

The working bit:

image

itamarst commented 10 months ago

Isolation is good reason for venv, but also system-wide installation is starting to be unsupported on newer Linux distributions, so people will get mysterious errors if they try to install globally.

Robinlovelace commented 10 months ago

Think this is good to merge. Unless there are any objections plan to do so today. Also if you're working on this ATM @michaeldorman (have seen your recent commits), quick review appreciated. Feel free to merge also.

michaeldorman commented 10 months ago

Think this is good to merge. Unless there are any objections plan to do so today. Also if you're working on this ATM @michaeldorman (have seen your recent commits), quick review appreciated. Feel free to merge also.

Looks good to me, thanks @Robinlovelace and everyone