geocompx / geocompy

Geocomputation with Python: an open source book and online resource for getting started in this space
https://py.geocompx.org/
Other
259 stars 47 forks source link

Switch geocoding from `osmnx` to `geopandas` #214

Closed michaeldorman closed 10 months ago

michaeldorman commented 10 months ago

Following @Nowosad comments and on second thought, I suggest not using osmnx for geocoding, here: https://py.geocompx.org/07-read-write#sec-geographic-data-packages since osmnx doesn't have a built-in way to deal with "no results". Instead, we can use geopandas as shown here: https://geopandas.org/en/stable/docs/user_guide/geocoding.html#geocoding Will be happy to hear any thoughts or other suggestions, thanks!

anitagraser commented 10 months ago

Looks great. Definitely worth a try

michaeldorman commented 10 months ago

Done https://github.com/geocompx/geocompy/commit/1fa5a334c1dccd32602737f6743cdb710ced54f5