search

geocortex / showcaser

Material Design inspired showcase view for the web
https://latitudegeo.github.io/showcaser/
MIT License
7 stars 4 forks source link

MD style for buttons #5

Open JosefJezek opened 7 years ago

JosefJezek commented 7 years ago

Button has bad padding, height and line-height, use px.

image

https://github.com/material-components/material-components-web/blob/master/packages/mdc-button/mdc-button.scss#L26

ianschmitz commented 7 years ago

We consciously made the decision to use em's for sizing if that is what you are referring to. Is there a specific problem you have observed?

JosefJezek commented 7 years ago

px's are better for pixel perfect design. MD specification define size in px. On top image is button GOT IT with bad vertical align text due em.

JosefJezek commented 7 years ago

https://material.io/guidelines/components/buttons.html#buttons-style

JosefJezek commented 7 years ago

Please same style for skip button. MD has consistent style for buttons in dialog.

ianschmitz commented 7 years ago

Thanks for the information. #8 should take care of it.