Closed TheBearodactyl closed 7 months ago
i dont like this, and terrible pr name
i feel like all of those updated dependencies is gonna break something, but also running cargo fmt just changes way too much, making this too big of a pr
i didn't run cargo fmt
, i used rustfmt
. also, It being too big of a pr is why i rebased and squashed the commits. also, why don't y'all have any tests to make sure it doesn't break? cargo has a builtin test framework
its still 1800 lines changed, but also rustfmt is the same thing
i didn't run
cargo fmt
, i usedrustfmt
. also, It being too big of a pr is why i rebased and squashed the commits. also, why don't y'all have any tests to make sure it doesn't break? cargo has a builtin test framework
tests suck
they don't lmao, you've just gotta get the hang of writing them. lemme implement a few real quick
can you please not have one big ass pr. either update the dependencies or format the code, not both
fiiiinee
also, i kept
Cargo.lock
this time (even though it's auto-generated every timecargo build
,cargo test
,cargo update
, etc. is run lmao). also, if you want to keepCargo.lock
, maybe consider removing it from.gitignore