geode-sdk / cli

Command-line utilities for working w/ geode
Boost Software License 1.0
24 stars 21 forks source link

run cargo format and update all deps #33

Closed TheBearodactyl closed 7 months ago

TheBearodactyl commented 7 months ago

also, i kept Cargo.lock this time (even though it's auto-generated every time cargo build, cargo test, cargo update, etc. is run lmao). also, if you want to keep Cargo.lock, maybe consider removing it from .gitignore

matcool commented 7 months ago

i dont like this, and terrible pr name

matcool commented 7 months ago

i feel like all of those updated dependencies is gonna break something, but also running cargo fmt just changes way too much, making this too big of a pr

TheBearodactyl commented 7 months ago

i didn't run cargo fmt, i used rustfmt. also, It being too big of a pr is why i rebased and squashed the commits. also, why don't y'all have any tests to make sure it doesn't break? cargo has a builtin test framework

matcool commented 7 months ago

its still 1800 lines changed, but also rustfmt is the same thing

matcool commented 7 months ago

i didn't run cargo fmt, i used rustfmt. also, It being too big of a pr is why i rebased and squashed the commits. also, why don't y'all have any tests to make sure it doesn't break? cargo has a builtin test framework

tests suck

TheBearodactyl commented 7 months ago

they don't lmao, you've just gotta get the hang of writing them. lemme implement a few real quick

matcool commented 7 months ago

can you please not have one big ass pr. either update the dependencies or format the code, not both

TheBearodactyl commented 7 months ago

fiiiinee