Open npstauff opened 7 months ago
Waiting for staff to comment "!accept" to accept the entry.
npstauff.hundred-lives
1.0.0
2.204
['windows']
2.0.0-beta.22
Waiting for staff to comment "!accept" to accept the entry.
npstauff.hundred-lives
1.0.0
2.204
['windows']
2.0.0-beta.22
Within ten minutes of using this mod, here are some issues i found: a mem crash
creator layer issues
and whatever this is
given the number of issues i found in the process of trying to reproduce the third screenshot, i have given up entirely
please resolve these issues on your own time
oh, one last thing: add @geode-sdk's Node IDs mod as a dependency in your mod.json
as well!
damn i must be microsoft with the amount of bugs im producing, sorry for making you go through ill work on fixing them
conflicts with globed, finally found it pinging @dankmeme01 as well
multiple issues that are blocking the accepting of this mod:
PlayLayer
to still exist in memory. This is also done in some other places, as whenever you call LivesLayer::scene
you use pushScene
instead of replaceScene
, which keeps the previous scene in memory, therefore leading to memory leaks.m_levelDownloadDelegate
after the download has finished or the user has exited the layer - currently it doesn't crash because the layers are leaked anyway, but in the future this will probably be an issue.Minor issues that won't lead to a rejection, but would still be nice to fix:
keyBackClicked
in your layer to know when the button is pressed)and whatever this is
This is a popup from my mod. It appears when you try to open a level, but the game already has a PlayLayer
So this means that this mod creates a PlayLayer. This popup also exists in Globed, as can be seen in your second screenshot.
let's goo, double the mod conflicts!
Your mod link
https://github.com/npstauff/Recent-Tab-Challenge/releases/download/initial/npstauff.hundred-lives.geode
Your mod source code
https://github.com/npstauff/Recent-Tab-Challenge
Your mod description
See how many recent tab levels you can beat with a set number of lives, skips, and practice runs. The levels are randomly selected, and you keep going through them until you run out of lives.