geode-sdk / indexer

Geode mod indexer system
21 stars 37 forks source link

Add Recent Tab Challenge #1655

Open npstauff opened 7 months ago

npstauff commented 7 months ago

Your mod link

https://github.com/npstauff/Recent-Tab-Challenge/releases/download/initial/npstauff.hundred-lives.geode

Your mod source code

https://github.com/npstauff/Recent-Tab-Challenge

Your mod description

See how many recent tab levels you can beat with a set number of lives, skips, and practice runs. The levels are randomly selected, and you keep going through them until you run out of lives.

github-actions[bot] commented 7 months ago

Waiting for staff to comment "!accept" to accept the entry.

Info:

github-actions[bot] commented 7 months ago

Waiting for staff to comment "!accept" to accept the entry.

Info:

RayDeeUx commented 7 months ago

Within ten minutes of using this mod, here are some issues i found: a mem crash

creator layer issues creator layer issues

and whatever this is and whatever this is

RayDeeUx commented 7 months ago

given the number of issues i found in the process of trying to reproduce the third screenshot, i have given up entirely

please resolve these issues on your own time

oh, one last thing: add @geode-sdk's Node IDs mod as a dependency in your mod.json as well!

npstauff commented 7 months ago

damn i must be microsoft with the amount of bugs im producing, sorry for making you go through ill work on fixing them

RayDeeUx commented 7 months ago

conflicts with globed, finally found it image pinging @dankmeme01 as well

dankmeme01 commented 7 months ago

multiple issues that are blocking the accepting of this mod:

  1. First attempt of using the mod ended up in a crash when trying to open the 1st level (crashlog 1, crashlog 2), seems to be somewhat reproducible by spamming the play button and the Ok button from the popup, but not very consistent.
  2. As reported above, this will break Globed (and potentially other mods), since rather than properly exiting a level you just push a new scene with your layer, causing the PlayLayer to still exist in memory. This is also done in some other places, as whenever you call LivesLayer::scene you use pushScene instead of replaceScene, which keeps the previous scene in memory, therefore leading to memory leaks.
  3. Another potential crash cause is not clearing m_levelDownloadDelegate after the download has finished or the user has exited the layer - currently it doesn't crash because the layers are leaked anyway, but in the future this will probably be an issue.

Minor issues that won't lead to a rejection, but would still be nice to fix:

  1. It is impossible to exit the challenge layer by pressing the Esc key (you can override keyBackClicked in your layer to know when the button is pressed)
  2. The UI of the mod is a bit over the place, the challenge button looks different from others (you can use a geode-provided blank texture to have a nice green gradient on your button), the position of the back button is inconsistent with other places in the game (it should be a bit higher), the skip button looks a bit out of place
mishpro-programm commented 7 months ago

and whatever this is and whatever this is

This is a popup from my mod. It appears when you try to open a level, but the game already has a PlayLayer

mishpro-programm commented 7 months ago

So this means that this mod creates a PlayLayer. This popup also exists in Globed, as can be seen in your second screenshot.

RayDeeUx commented 7 months ago

let's goo, double the mod conflicts!

npstauff commented 7 months ago

image