geode-sdk / indexer

Geode mod indexer system
24 stars 39 forks source link

Add Level History v1.0.1 #1878

Closed SergeyMC9730 closed 2 weeks ago

SergeyMC9730 commented 3 weeks ago

Your mod link

https://github.com/SergeyMC9730/levelhistory/releases/download/v1.0.1/dogotrigger.level_history.geode

Your mod source code

https://github.com/SergeyMC9730/levelhistory

Your mod description

Look through and play deleted and outdated levels using GDHistory or other sources

github-actions[bot] commented 3 weeks ago

Waiting for staff to comment "!accept" to accept the entry.

Info:

OM3GA6400 commented 2 weeks ago

you should make is so you can copy the levels

SergeyMC9730 commented 2 weeks ago

you should make is so you can copy the levels

in v1.0.2 or v1.1.0 (cuz i would need to additional popup for more than 3 level actions buttons)

SergeyMC9730 commented 2 weeks ago

:/

OM3GA6400 commented 2 weeks ago

:/

bro the mods hate you

Cvolton commented 2 weeks ago

in gdhistory provider:

found a typo

PARSE_INT(level->m_ratings, leveljson["raiting"]);
PARSE_INT(level->m_ratingsSum, leveljson["raiting_sum"]);

feature score is level->m_featured, m_rateFeature is whether the level was sent for feature (which is not exposed by gdhistory, even though the db has the value logged for a few levels)


also while adding the button to other-filter-menu, you should just call updateLayout on it and let the layout handle the positioning, otherwise it will overlap with loquibot and other mods that use this menu

Cvolton commented 2 weeks ago

also the loading circle doesnt disappear for me sometimes and the non-functional get it button is kinda weird

also ive just noticed that the code already more or less emulates the layout behavior and the other things arent blocking issues per se, so im accepting but it would be nice to see them resolved

Cvolton commented 2 weeks ago

!accept

github-actions[bot] commented 2 weeks ago

Successfully added the mod!