In admin, remove "License Info" page

[jonyo]

The page should be removed. The current solution was very quick hack, but it leaves the old buttons and everything. Probably don't need the page anymore at all.

[vicos59]

I'll take a stab at this now.

[vicos59]

• [x] src\admin\admin_classauction_tools.php (misc functions, not just license)
• [x] src\admin\menus\sections\admin_tools.php (Left col menu that links to the page)
• [x] src\admin\templates\licenseInfo.tpl (The actual License Info page)

functions in admin_tools.php:

display_admin_tools_license() update_admin_tools_license()

Search did not reveal any other files calling these functions. I guess they are orphans and I can remove them.

[vicos59]

@jonyo Would you please check src\admin\menus\sections\admin_tools.php

That file and most/many/several of the other in that dir do not close the <?php ?> tag at the bottom of the file.

Is it supposed to be this way? or did something go horribly wrong once before?

[jonyo]

@jonyo Would you please check src\admin\menus\sections\admin_tools.php

That file and most/many/several of the other in that dir do not close the <?php ?> tag at the bottom of the file.

Is it supposed to be this way? or did something go horribly wrong once before?

Just reading this.

About the closing ?> tag - yes it is normal to leave that off of "code only" files (which means almost all of the files since the software uses Smarty templates currently), and in fact is recommended to avoid inadvertently inserting extra white space on the page before you mean to. Which is not good if you want to set a cookie or something, you can't if some whitespace is already sent.

[jonyo]

See also: see the notes at the bottom of the php tags documentation