search

geodesicsolutions-community / geocore-community

GeoCore Community, open source classifieds and auctions software
MIT License
9 stars 6 forks source link

Getting Started Checklist: Set site/company name in header/footer checks are bogus #116

Open vicos59 opened 2 years ago

vicos59 commented 2 years ago

http://localhost:8080/admin/index.php?page=checklist&mc=getting_started

aaaaaa

Both just search for a string in the respective header and footer templates. However, since this was written, that data was moved to the database.

Either completely remove the checks, or update the scripts that do the testing to look in the proper location.

src\admin\getting_started_checks\design_headerWebsiteName.php

src\admin\getting_started_checks\design_footerCompanyName.php

jonyo commented 2 years ago

@vicos59 By the way, if you did not notice it yet:

Since you are in the tester group, I think you should be able to add labels and milestones now on issues and PR's and probably other things. AKA "triage" the issues. If you so feel inclined. That is assuming I got the permissions correct, so if it does not let you, report back so I can fix it if needed.

vicos59 commented 2 years ago

I was thinking it might be nice to have a tag to prioritize issues. I just did this for my personal project I imported to GitHub.

Be nice to know which ones are priority and need to be fixed before we can release the 1st production release. Some of these are not really showstoppers or even required for the 1st release.

jonyo commented 2 years ago

We can make a milestone for 20.0.0 final. Or we could make a label for blocker that means it is blocking the next release from going out until it is fixed.

Thinking about it, maybe using milestone targets is better, since "levels" are kind of subjective, but having something set to be released for a certain version is clear the goal is to have it fixed by then. It is much more concrete vs. a priority level that might need to be explained or something.

vicos59 commented 2 years ago

Sounds like milestone is the winner. I need to be able to see what needs to be done to get v20.0 released so I can see where I can help and attack the highest priorities first. Without a goal, we will never get there.

After that, we can debate if things on the v20 milestone really need to be there. The sooner we can get others to adopt GeoCoreCE, the faster the project will move forward.