search

geodesicsolutions-community / geocore-community

GeoCore Community, open source classifieds and auctions software
MIT License
9 stars 6 forks source link

Replaces sample banners with a generic vs real affiliate banners #118

Closed vicos59 closed 2 years ago

vicos59 commented 2 years ago

Fixes #81

It also fixes the respective Getting Started Checklist, which was broken in v18. (someone changed the banners in the templates and did not update the scripts to check for the existence of the new file names.)

There are 2 issues:

1) I added \geo_templates\default\external\images\banners\sample_300x100.jpg

However, git is not picking this up and I do not know why.

2) I had to fix .git\hooks\pre-commit

Git was complaining about \r when I tried to commit changes.

vicos59 commented 2 years ago

I manually added sample_300x100.jpg to Github.

vicos59 commented 2 years ago

Just committed 3 files to remove the dev comments from the templates. I have no idea why it is showing the entire file as removed then everything added as new.

vicos59 commented 2 years ago

@jonyo See if this makes you happy.

I created Issue #122 to handle the rest of the potentially obsolete images. Too many higher priorities to deal with to worry about that right now.

jonyo commented 2 years ago

@vicos59

I guess cs-fix "fixed" those.

Hmm, I bet this has to do with line ending settings, it might be fixed once I do #119 - at least I think that might be why. When I run cs-fix myself it does not try to do that.

By the way, that thing you gave a screenshot for, it is saying "before" there was no line ending at the end of the file, and after there is. So cs-fix added a newline at the end of all those files. Which I thought was already done.

In either case, I'll look into it and if it turns out there are still files that it missed when I run cs-fix in my local, maybe do a dedicated commit that only makes those whitespace changes if needed. I want to verify it is not related to windows line ending though so I'll do it in a different PR.

jonyo commented 2 years ago

@vicos59 Also like I mentioned on the other PR, can you update the PR title? Like I mentioned, the titles are used for the release changelog.

Its best if they have short description of the change, and if anyone wants more details they can then click on the PR to see it. (instead of forcing you to click on every single one to see what it changed)