Remove remaining instances of 'geodesicsolutions.com' from codebase

[vicos59]

My search reveals:

• [ ] src\addons\bulk_uploader\docs\example_upload_auctions.txt #18
• [ ] src\addons\bulk_uploader\docs\example_with_title.txt #18
• [x] src\admin\AJAXController\homeLicense.php #76
• [x] src\classes\php5_classes\Template.class.php (Magically fixed somewhere else)
• [x] src\pre_setup\index.php Picked up in #147
• [x] src\setup\product.php #124
• [x] src\setup\steps\layout.php Picked up in #147
• [x] Legacy Changelogs #143
• [ ] src\upgrade\versions\pre_2.0.10\index.php #152
• [ ] src\sql\data_misc.sql #152
• [ ] src\upgrade\versions\3.1_to_4.0\conditional_sql.php #152

Several of these are email addresses, so @jonyo will need to decide what to use in their place.

[vicos59]

There are also many changelogs with 'geodesicsolutions.com' which I elected not to list above.

Do we care?

[jonyo]

There are also many changelogs with 'geodesicsolutions.com' which I elected not to list above.

Do we care?

Hmm, so the links all go to the old bugzilla bug tracker. A few years back when Geo was still around and they contracted me to help recover the database, the bug tracker was one that was completely corrupted. And if I remember correctly, it was behind a login, so it won't show up in wayback.

So I say... Maybe make a short page in the wiki saying something like the above, that the old bug tracker was corrupted and no longer available so the advanced details for each issue is lost. Then change the links to go there.

It may be a big enough of a task to be its own PR / issue.

[jonyo]

@vicos59 I have done the same search in the past, and as a result, some of these have their own issues already:

• [ ] src\addons\bulk_uploader\docs\example_upload_auctions.txt
• [ ] src\addons\bulk_uploader\docs\example_with_title.txt

See #18

• [ ] src\admin\AJAXController\homeLicense.php

See #76

It is good to have this issue even if the other parts are handled on their own, so we have an overall issue we can keep open until every spot is done.

Several of these are email addresses, so @jonyo will need to decide what to use in their place.

It will probably need to be case by case. For instance, if it is a spot saying "contact support" - I've just been removing that. But I just thought of an alternative, we can maybe link to discussions or something instead... I've already removed a number of them but any other spots, maybe it would be good to change it to something like Ask for help in the community discussion with link. If you think that is a good idea too we can do that.

[vicos59]

It may be a big enough of a task to be its own PR / issue.

Agree! Something that trivial should not hold up 20.0.0

[vicos59]

See #143 to handle old legacy changelogs

[vicos59]

Can src\sql\data_misc.sql be edited in VSC or is it a generated file?

[jonyo]

Can src\sql\data_misc.sql be edited in VSC or is it a generated file?

All of those SQL files can be edited directly, with the exception of the one for translations. That one uses a tool to update, where it adds new entries for you since adding new translations is pretty complicated.

That said, the way translations works is a different subject, my personal plan for that was once we need new translations (so basically when we are to a point we are adding new features): I want to look into switching to a different system for internationalization / translations. Maybe we can use gettext since that is one of the easiest. Anyways I was planning to flesh it out further later, it is a little early now in 20 which is supposed to be the compatibility release.