search

geodesicsolutions-community / geocore-community

GeoCore Community, open source classifieds and auctions software
MIT License
9 stars 6 forks source link

Fixing PHP 8 issues on grid view, including changes to main_page temp… #136

Closed jonyo closed 2 years ago

jonyo commented 2 years ago

…lates

Note: Affects main_page templates

What this means: If you are upgrading from a previous version, you may need to make this same change in your grid.tpl file if you have one in your own template set.

If you do not make a change it could have compatibility issues if/when you try running your website in PHP8.

We will likely need to add something to the upgrade instructions for this one as well. Luckily the change in the template is not too complicated.

jonyo commented 2 years ago

I just noticed the whitespace changes, I thought I had all those fixed already... (╯°□°）╯︵ ┻━┻

When looking at the diff on this one, click the little settings gear thing and make it "ignore whitespace" to see what was actually fixed.

I'm going to see about fixing any of those across the board so they don't show up in random PR's.