geodesicsolutions-community / geocore-community

GeoCore Community, open source classifieds and auctions software
MIT License
9 stars 6 forks source link

Remove unnecessary code pertaining to licensing/leasing/etc #150

Open vicos59 opened 2 years ago

vicos59 commented 2 years ago

What is all this whitelab, turbo, and leased stuff?

They had a bunch of options they experimented with over the years for different payment models. If you are curious:

What I would do is remove the front end parts that are not used or needed, then look at what was removed, look at the back end and remove the stuff that tries to set it.

When I'm doing a search and destroy like this, I find it helps to keep notes. Like I make a checklist, if I remove a thing I add it to the checklist. Once I'm done I go over the checklist items, searching the code for places that still use each one. If I find one and it turns out it is still needed, I leave it. If I find another use but that other place maybe is not needed, I add it to the list and keep going. It involves lots of going over the same items until you either remove all the sub-parts then the thing itself, or you run into a place that needs it to stay so you check it off that way.

Since it is pretty heavy with the old licensing checks, I can take this one over if you want. I also have access to the original git repo so I can look at the history that might help determine if something is still needed or not. Just let me know.

Originally posted by @jonyo in https://github.com/geodesicsolutions-community/geocore-community/issues/147#issuecomment-1061806267

vicos59 commented 2 years ago

See also #92