search

geodesymiami / insarmaps

3 stars 0 forks source link

Can't select end date in displacement time series window #53

Closed falkamelung closed 1 year ago

falkamelung commented 2 years ago

Occasionaly I can't select the end date in time series window. It let's you select the start date and then it is doing things on its own. Try this example:

https://insarmaps.miami.edu/start/19.4779/-155.5690/11.9600?flyToDatasetCenter=false&startDataset=CSK_SM_091_0000_20180916_XXXXXXXX&minScale=4&maxScale=-4

I can select the start date but then it does things without letting me select the end date as shown here:

https://user-images.githubusercontent.com/11162588/139192335-556a8d15-846a-402a-9905-26e472d58cc3.mov

Once you have fixed this please also verify this example. The display gets scrambled as shown in the video/

https://insarmaps.miami.edu/start/19.4779/-155.5690/11.9600?flyToDatasetCenter=false&startDataset=CSK_SM_091_0000_20180916_XXXXXXXX&minScale=4&maxScale=-4&pointLat=19.46509&pointLon=-155.57562&startDate=20210316&endDate=20210924

https://user-images.githubusercontent.com/11162588/135772418-07ff7837-b2c8-4bb5-8fe0-69e994602032.mov

stackTom commented 1 year ago

This dataset seems to be deleted. Do you have another dataset I can use to reproduce this issue?

falkamelung commented 1 year ago

It happens with almost every dataset. Do you think you have it fixed already? Then I should try many to see whether it still happens.

stackTom commented 1 year ago

Possibly

falkamelung commented 1 year ago

For Sentinel-1 sensor it works fine (high-res and others), except a possible memory leak (more on that later). However for a different sensor (CSK) it does not work and the image get scrambled. Try this one and change the time period:

129.213.120.104/start/19.4880/-155.3734/9.1363?flyToDatasetCenter=false&startDataset=CSK_SM_091_0000_20180916_XXXXXXXX_N19330_N19578_W155725_W155430&pointLat=19.45323&pointLon=-155.55518&minScale=-3&maxScale=3&startDate=20190122&endDate=20200804

image
stackTom commented 1 year ago

I can't seem to reproduce it. I've seen this before as well but I can't consistently cause it. Do you know which conditions cause it? Maybe we just need to re upload those old datasets?

Also, what is the memory leak?

falkamelung commented 1 year ago

That is weird. OK Will re-ingest later and look at it some more.

Regarding possible memory leak, please try this data set http://129.213.120.104/start/19.4880/-155.3734/9.1363?flyToDatasetCenter=false&startDataset=S1_IW12_087_0527_0531_20141116_XXXXXXXX_N19391_N19549_W155679_W155506&minScale=-3&maxScale=3 and select a few times starting and end date. It gets very slow.

Then, after interupting using ESC it works fine again

stackTom commented 1 year ago

I see what you mean. There is definitely a memory leak, good catch. I updated to the latest mapbox gl js. We were on version ~0.44 and the latest is 2.9.2, so we were very outdated. The new one doesn't suffer from the same slowdown when you recolor multiple times. Memory usage is also down significantly, so it appears they fixed whatever memory issue was there.

However, going from 0.44 to 2.9.2 is a huge change. I'm sure things will break (hopefully not) so keep an eye out for new weird bugs.

stackTom commented 1 year ago

Maybe this also fixes the scrambling we see above. Let's keep using the site, if after a month or so the above issues aren't reproducible, let's close this issue as fixed.