geodesystems / ramadda

RAMADDA Data Repository
https://geodesystems.com
Apache License 2.0
20 stars 5 forks source link

There seems to be an arbitrary limit on the number of server-side files shown in an entry page. #5

Open paul-breen opened 6 months ago

paul-breen commented 6 months ago

We've noticed that one of our Ramadda entries that exposes a directory hierarchy of server-side files has an arbitrary limit on the number of (synth) file entries it will show for a given directory.

For example, one of the directories actually has 2851 files, but Ramadda only shows 999 of them. This is a showstopper for us. We have many other entries with actual file counts > 999.

How can we raise or remove this limit? I've had a look in the entry page and the admin pages but can't find anything that affects this limit. In the entry page, there's a property called 'Order' which was set to 999, and I was hopeful that this would be what I was looking for, but alas, raising it didn't make any difference.

Any insight on this is gratefully received.

paul-breen commented 6 months ago

After much digging, I see that there's a max URL query parameter. Setting this to a number greater than the count of files enables all files to be shown, and includes simple pagination controls at the top of the file list table.

In the default state, it's not obvious to the user that there are additional files that they can't see, and it seems unreasonable for them to have to add this URL query parameter to the URL to be able to paginate all files.

So as originally stated, is there a way to remove this arbitrary limit and to always show all files? Failing that, is there a way to force the max URL query parameter to always be present in the Ramadda URLs, so that at least it's clear to the user that they can paginate to see additional files?

jeffmcwhirter commented 6 months ago

Hi Paul, I just pushed out a new release that makes the max # of children entries configurable via a system property- https://ramadda.org/repository/userguide/faq.html#maxentries

Just set the property, e.g. ramadda.defaultmaxentries=4000 in the repository.properties file in the RAMADDA home directory on your server

I did notice that the entry table does not support paging. It probably should and I will look into that but for now increasing the max # entries should address your problem

-Jeff

On Fri, Apr 26, 2024 at 8:47 AM paul-breen @.***> wrote:

After much digging, I see that there's a max URL query parameter. Setting this to a number greater than the count of files enables all files to be shown, and includes simple pagination controls at the top of the file list table.

In the default state, it's not obvious to the user that there are additional files that they can't see, and it seems unreasonable for them to have to add this URL query parameter to the URL to be able to paginate all files.

So as originally stated, is there a way to remove this arbitrary limit and to always show all files? Failing that, is there a way to force the max URL query parameter to always be present in the Ramadda URLs, so that at least it's clear to the user that they can paginate to see additional files?

— Reply to this email directly, view it on GitHub https://github.com/geodesystems/ramadda/issues/5#issuecomment-2079542459, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANCOT3XCWMHNAFHZ77DJOTY7JSJVAVCNFSM6AAAAABG2OEJOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZZGU2DENBVHE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

paul-breen commented 6 months ago

Yeah, that's great. Thanks Jeff!

paul-breen commented 2 months ago

Hi Jeff,

Just to follow up on this. We've deployed the version above with the fix and it solves our issue. Thanks very much.

In your comment above, you mention that you might look into adding paging to the entry tables. Have you done that yet?

jeffmcwhirter commented 2 months ago

Hi Paul, Sorry, I haven't had a chance to look into that. I will put it on my summer todo list

-Jeff

On Wed, Aug 21, 2024 at 8:34 AM paul-breen @.***> wrote:

Hi Jeff,

Just to follow up on this. We've deployed the version above with the fix and it solves our issue. Thanks very much.

In your comment above, you mention that you might look into adding paging to the entry tables. Have you done that yet?

— Reply to this email directly, view it on GitHub https://github.com/geodesystems/ramadda/issues/5#issuecomment-2302205614, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANCOT7LE7KYZHQDAZEGX4DZSSQRFAVCNFSM6AAAAABG2OEJOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBSGIYDKNRRGQ . You are receiving this because you commented.Message ID: @.***>

jeffmcwhirter commented 2 months ago

Hi Paul, It turns out the infrastructure was already in place for paging it just wasn't showing up. I have made a new release that has this.

If showing the entry table you'll get next/prev paging buttons if the number of entries shown >= the max # of entries, e.g. here is an example where max is exlplicity set to 5 https://ramadda.org/repository/entry/show?entryid=88322c2d-ba89-4fe1-8bef-71a44e400940

Don't hesitate to get back to me if you have any issues -Jeff [image: image.png]

On Wed, Aug 21, 2024 at 11:13 AM Jeff McWhirter @.***> wrote:

Hi Paul, Sorry, I haven't had a chance to look into that. I will put it on my summer todo list

-Jeff

On Wed, Aug 21, 2024 at 8:34 AM paul-breen @.***> wrote:

Hi Jeff,

Just to follow up on this. We've deployed the version above with the fix and it solves our issue. Thanks very much.

In your comment above, you mention that you might look into adding paging to the entry tables. Have you done that yet?

— Reply to this email directly, view it on GitHub https://github.com/geodesystems/ramadda/issues/5#issuecomment-2302205614, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANCOT7LE7KYZHQDAZEGX4DZSSQRFAVCNFSM6AAAAABG2OEJOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBSGIYDKNRRGQ . You are receiving this because you commented.Message ID: @.***>

paul-breen commented 2 months ago

Hi Jeff,

Yeah, I'd noticed that there was paging functionality available, but that it didn't appear unless you manipulated the entry URL, which of course isn't suitable for end users to do.

Great, I'll look at getting this release deployed.

Thanks again, Paul.