search

geodienst / lighthousemap

OpenStreetMap's Blinking Beacons
https://geodienst.github.io/lighthousemap/
MIT License
289 stars 50 forks source link

Missing node? #7

Closed gerwitz closed 2 years ago

gerwitz commented 2 years ago

I noticed my most nearby lighthouse was not represented, so I went to OSM to add it. But it is already there (of course, because the Dutch love OSM). Maybe this is filtered out, but it seems the Overpass API should be returning this:

https://www.openstreetmap.org/node/1375241392

jamesscottbrown commented 2 years ago

It looks like the issue is that the light sequence is expressed as text in the description field, rather than in the seamark:light:sequence field (as it is in e.g., Gilkicker Point).

gwynna commented 2 years ago

Also have a missing lighthouse opposite me! https://www.openstreetmap.org/way/673396687 Newbie so have no idea how to add sorry

Asheboy commented 2 years ago

@jamesscottbrown is seamark:light:sequence the right tag to use? I see this lighthouse has seamark:light:1:sequence instead. Should I update it to use seamark:light:sequence instead?

jamesscottbrown commented 2 years ago

The use of numbers like seamark:light:1:sequence or seamark:light:2:sequence is necessary where there are sector lights (essentially several lights at the same location, each only visible from a certain range of angles) - this is an example of such a light.

This this map doesn't currently support sectored lights - see Issue #1.

I don't know if there's any good reason to use seamark:light:1:sequence rather than seamark:light:sequence if there is only one light to record.

TagInfo provides some information about the use of the seamark:light:sequence (8 490 uses) and seamark:light:1:sequence (5 276 uses) tags.

PierreMesure commented 2 years ago

I missed you last message @jamesscottbrown but I came to the same conclusions by looking at the code.

So I made a PR to fetch sectored lights and add basic support for them (basically using the first light's characteristics).

Here's the result. What do you think?

gerwitz commented 2 years ago

Thanks for the diagnostic, @jamesscottbrown, I've edited this node. After it's been reviewed and I see it reflected here, I think I have a lot of work to do updating Dutch lighthouses.

leonmvd commented 2 years ago

Thanks a lot @PierreMesure we've merged the PR with some minor changes. If you guys edit the data for these lighthouses in osm it should show up on the map the next day or so