search

geodynamics / Rayleigh

Rayleigh: Pseudo-spectral MHD
GNU General Public License v3.0
59 stars 48 forks source link

ref%dsdr should now be scalable by constant c_11 #489

Closed illorenzo7 closed 9 months ago

illorenzo7 commented 9 months ago

All terms in the PDEs have constants out front that can scale the terms, except for the reference entropy advection term f_14. This pull request would insert a new constant (c_11) that can scale ref%dsdr in the custom framework and takes on an appropriate value for the other reference_type's.

feathern commented 9 months ago

Hi Loren, This looks good, and I think it's a good idea. Can you also add a small update to the documentation so that c11 is included there as well? Then I'll do a full review/merge etc.

-Nick

illorenzo7 commented 9 months ago

OK, c_11 should now be properly included in documentation. I also noticed nonzero dS/dr was still present for reference_type 3 (but it gets set to zero there) so I corrected that as well.

I realize I never put the general anelastic mode in the doc, I will do that in a separate pull request.

feathern commented 9 months ago

Thank's for updating the documentation. I'm almost good with this now, but have one small request. Can you remove the two debugging statements "got here" and "actually got here"? After that, I'll approve and merge. -Nick

feathern commented 9 months ago

Actually, I'll do that in a separate PR momentarily just for expediency.