search

geodynamics / Rayleigh

Rayleigh: Pseudo-spectral MHD
GNU General Public License v3.0
61 stars 48 forks source link

Fix eqcoeff version number #495

Closed illorenzo7 closed 6 months ago

illorenzo7 commented 10 months ago

Pull request #489 inadvertently broke the equation_coefficients file, and how it is interpreted by post_processing/rayleigh_diagnostics. I should have updated the version number from 1-->2 since I changed the number of constants from 10 to 11.

This pull request updates the version number, and also the rayleigh_diagnostics class to read in the equation_coefficients file. I verified it still works on old version=1 equation_coefficients files.

This pull request additionally addresses issue #491, since in version 2, "nconst" and "nfunc" are explicitly written into equation_coefficients.

feathern commented 7 months ago

Or, alternatively, we could set c11 to 1 for version 1. Then it won't rescale dsdr, if it's set. I think that might be the better route, actually.