[wip] Simplified and minimal update to include pseudo-incompressibility

geodynamics / Rayleigh

Rayleigh: Pseudo-spectral MHD

GNU General Public License v3.0

59 stars 49 forks source link

[wip] Simplified and minimal update to include pseudo-incompressibility #564

Closed BWHindman closed 2 weeks ago

BWHindman commented 1 month ago

Added the capability to switch from anelastic to the pseudo-incompressible approximation. With pseudo-incompressibility turned off, it has run the hydro anelastic benchmark on Pleiades without throwing errors, but it ran incredible slow. Made as a draft pull to allow other developers to check the implementation.

feathern commented 1 month ago

You'll have to set this to a non-draft before I can merge. If you want to wait until Pleiades is up so we can test the speed once more, that's fine with me. Everything you described offline sounds like one of your nodes had a memory problem.

BWHindman commented 2 weeks ago

I believe that I hit all the correct buttons to convert this pull request from a draft to a "ready to merge" request. Should be good to go.

feathern commented 2 weeks ago

Great. I just ran some tests to be extra sure, and there is no measurable speed difference between your version and the main-branch version of Rayleigh. I suspect what you saw on the NASA systems was just another symptom of the old hardware.