search

geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
224 stars 235 forks source link

Refine right away at first timestep #1690

Closed jaustermann closed 6 years ago

jaustermann commented 7 years ago

It would be nice if we could check whether the refinement strategy depends on the solution of the first timestep and if it doesn't (e.g. boundary, topography) refine right away without calculating the solution first. This only matters for the initial refinement.

gassmoeller commented 7 years ago

Hi Jacky, if you are still interested in this, I think it should not be too hard to implement. I could imagine a parameter in the mesh refinement section called Skip initial adaptive refinement solves, which contains documentation that it is only save to set this to true if the refinement criteria are independent of the solution. Then one would only need to modify core.cc:2309-2314 to include a loop that calls maybe_do_initial_refinement until no more initial refinement is done, and then one final goto start_time_iteration to actually solve for the final mesh. Do you want to give this a try?

jaustermann commented 7 years ago

Hi Rene, thanks for the pointers! I will give this a try.

bobmyhill commented 6 years ago

@jaustermann do you want to assign this to yourself?

jaustermann commented 6 years ago

@bobmyhill I haven't worked on this yet so feel free to tackle it if you want

bobmyhill commented 6 years ago

Ok, this is mine!

jaustermann commented 6 years ago

This is addressed by #2409.