search

geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
223 stars 235 forks source link

Add missing derivative term to the Newton preconditioner matrix #2118

Open bangerth opened 6 years ago

bangerth commented 6 years ago

1967 points out that the Newton preconditioner term is still missing the compressibility term. While looking at #2116, I also noted that the Newton preconditioner would likely also be better if it had a contribution of the derivatives to the Schur complement: The factor 1/eta is likely sub-optimal, I think we need something of the sort of 1/(eta + deta/eps : eps(u)) or similar. What exactly remains to be found out, and tested.

gassmoeller commented 6 years ago

Is this going to happen within the next 1-2 weeks? Otherwise lets postpone it until after the release. We need to make the ASPECT release before the deal.II release (due to incompatibility between ASPECT 1.5 and deal.II 9.0).

bangerth commented 6 years ago

Not likely. Let's bump it.