search

geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
228 stars 238 forks source link

Spherical shell and chunk support for initial topography #2757

Open wouterjanssen opened 5 years ago

wouterjanssen commented 5 years ago

Hi all, My name is Wouter and i'm relatively new to working with GitHub and ASPECT. I am currently working on a thesis under supervision of Dr. Cedric Thieulot.

I had a question regarding the support of spherical shell and chunk geometries when using initial topography from ascii data file. It seems this support has been removed recently (from the documentation at least). I was wondering if, by any chance, this is currently being worked on by anyone and if yes, when this is expected to implemented.

Kind regards, Wouter

gassmoeller commented 5 years ago

Hi Wouter, on first glimpse I do not see why the ascii data initial topography should not work for a spherical shell or chunk. Did you try to use it and have a specific error message, or could you link to a place where this change was discussed? I am not personally working much on the initial topography part, if you have more in-depth questions @anne-glerum or @MFraters might be able to add more.

wouterjanssen commented 5 years ago

2702

I have tried it before the christmas break, and could indeed not get it to load the ascii data files for chunk&shell. Whenever i try:

Loading new data file did not succeed. Assuming constant boundary conditions for rest of model run.

gassmoeller commented 5 years ago

Ah I missed that change. However, it only affects the documentation so if it worked before it should still work. And John also stated that he had no proof that it does not work, so maybe we should just try.

The error message that you posted seems to be unrelated to the initial topography model. It says 'Assuming constant boundary conditions for the rest of model run` which means it was probably written by the one of the ascii data boundary condition plugins (e.g. velocity or temperature). Also this message does not cancel a model run, it is only a warning that says that the plugin did not find the next file (it had to find at least one, otherwise it would have complained about not finding any file). Using a different boundary condition (something other than ascii data) should make the message disappear. What happened after this message appeared, did the model continue? Can you post a log.txt file for the model?

naliboff commented 5 years ago

@gassmoeller - Both @LudovicJnnt and I tried to add surface topography to a chunk geometry without success. I then noticed that there is an open PR #1705 to do exactly this and changed the documentation in #2702 to reflect the functionality is not yet implemented.

I don't recall why I said "I have not tried a test case" in that PR, but both Ludo and I had indeed tried to add topography to our own models with a chunk geometry by that point. I should have made that clear, sorry about that.

I'll try to rebase #1705 to master later today or tomorrow and see if the preliminary functionality still works. Multiple other groups actually inquired about this functionality at AGU.

wouterjanssen commented 5 years ago

Thanks for the clarifications. I look forward to hearing from you!