search

geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
224 stars 235 forks source link

Avoid specifying input values and calculating material properties for masked compositional fields #4182

Open anne-glerum opened 3 years ago

anne-glerum commented 3 years ago

When compositional fields are used to track parameters other than lithology, say elastic stress, they are masked in the material model. However, the user still needs to provide material parameters for them, like diffusion prefactor, density etc. For 9 elastic stresses + lithologies, this can lead to long lists of parameters. The function parse_map_to_double_array used to read in the lists of parameters has a flag allow_missing_keys. Maybe we can allow missing values for masked fields?

Also, viscosity and other properties are still computed for masked fields, but they have a zero contribution to the average value because their volume fraction is zero. Can we avoid computing material properties for masked fields?

As discussed with @naliboff, @bobmyhill, @erinheilman and @elodie-kendall.

tjhei commented 3 years ago

Would it make sense to add additional classification for compositional fields? This information could be used consistently throughout to help here.