geodynamics / aspect

A parallel, extensible finite element code to simulate convection in both 2D and 3D models.
https://aspect.geodynamics.org/
Other
223 stars 235 forks source link

Improve field parsing #4246

Open bobmyhill opened 3 years ago

bobmyhill commented 3 years ago

ASPECT has "compositional" fields not only for compositions, but also other properties like grain size and stress (and soon, a lot of other fields with the updates planned by @MFraters). Some material models require certain fields in specific (but different) orders, and different rheologies don't play nicely with the others. With the increasing modularisation of the material models, I think this may become a significant stumbling block.

Some potential improvements:

Some of these changes are likely to break backwards compatibility, so I'm opening the issue for discussion.

tjhei commented 3 years ago

Agreed. I think we should have a conversation about this.

Related #4182

naliboff commented 3 years ago

Agree this needs to be discussed and that many of the proposed changes are needed, regardless of whether backwards compatibility is broken. #3927 is also related.