Closed cedrict closed 4 months ago
@gassmoeller I believe I have addressed all your comments.
There is no new commit since my review. Did you forget to push? There is also a conflict with main that needs to be resolved, maybe that blocked your push.
@gassmoeller hi, I guess I forgot to push indeed, weird... thanks for bringing this up
@gassmoeller hope this is all good now
/rebuild
The basic idea is to only authorize strain softening for a given range of temperatures, parameterized by T0,T1,T2,T3 (see figure in strain_dependent.cc. A colleague of mine and myself need this feature for an article (in prep). Once the basic structure of the code will be validated, I will add a test.